Add new setting //go/toolchain:sdk_name to allow the selection of a specific Go toolchain #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific Go toolchain This commit adds a new setting --@io_bazel_rules_go//go/toolchain:sdk_name which can be used to select a registered Go toolchain via the name provided in go_download_sdk, go_wrap_sdk, etc. This fixes the problem of selecting a toolchain where the same Go version is used, but different experiements are enabled or patches applied. Fixes bazel-contrib#4240
fmeum
reviewed
Jan 30, 2025
| @@ -200,6 +200,33 @@ def declare_bazel_toolchains( | |||
| visibility = ["//visibility:private"], | |||
| ) | |||
|
|
|||
| sdk_name_label = Label("//go/toolchain:sdk_name") | |||
There was a problem hiding this comment.
You can inline this and drop the Label(...) call, config_setting properly converts its attributes.
| native.config_setting( | ||
| name = prefix + "match_sdk_name", | ||
| flag_values = { | ||
| sdk_name_label: go_toolchain_repo[1:] if go_toolchain_repo.startswith("@") else go_toolchain_repo, |
There was a problem hiding this comment.
I would like to avoid this kind of ad-hoc parsing. Can we arrange for the correct name to be passed in as an argument to the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This commit adds a new setting
--@io_bazel_rules_go//go/toolchain:sdk_name which can be used to select a registered Go toolchain via the name provided in go_download_sdk, go_wrap_sdk, etc.
This fixes the problem of selecting a toolchain where the same Go version is used, but different experiements are enabled or patches applied.
Which issues(s) does this PR fix?
Fixes #4240
Other notes for review
Works also as a workaround for #3582