Update Go SDK to 1.23.1 #4105
Merged
Update Go SDK to 1.23.1 #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Go SDK with Bzlmod is kept at 1.22.7. Requires an update to golang.org/x/tools to avoid nogo silently failing to generate facts files with the new SDK. Also requires an update to golang.org/x/net to fix bettercap/bettercap#1106.
linzhp
approved these changes
Sep 18, 2024
peng3141
pushed a commit
to peng3141/rules_go
that referenced
this pull request
Sep 24, 2024
**What type of PR is this?** Feature **What does this PR do? Why is it needed?** The default Go SDK with Bzlmod is kept at 1.22.7 as 1.23 is breaking in a number of ways and we don't want to force this onto every module as the default just yet. Requires an update to golang.org/x/tools to avoid nogo silently failing to generate facts files with the new SDK. **Which issues(s) does this PR fix?** **Other notes for review**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The default Go SDK with Bzlmod is kept at 1.22.7 as 1.23 is breaking in a number of ways and we don't want to force this onto every module as the default just yet.
Requires an update to golang.org/x/tools to avoid nogo silently failing to generate facts files with the new SDK.
Which issues(s) does this PR fix?
Other notes for review