Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix library attr implementation for tests. #32

Closed
wants to merge 1 commit into from
Closed

Fix library attr implementation for tests. #32

wants to merge 1 commit into from

Conversation

swsnider
Copy link
Contributor

@swsnider swsnider commented Jun 5, 2016

This was broken when the referenced library had transitive deps.

Fixes #6.

@swsnider
Fix library attr implementation for tests.
003f9bc 
This was broken when the referenced library had transitive deps.
@bazel-io
Copy link

bazel-io commented Jun 5, 2016

Can one of the admins verify this patch?

@swsnider
Copy link
Contributor Author

swsnider commented Jun 5, 2016

If I should be pushing to a gerrit instance instead, please let me know.

@yugui yugui self-assigned this Jun 5, 2016
@yugui yugui mentioned this pull request Jun 6, 2016
Merged
@yugui
Copy link
Contributor

yugui commented Jun 6, 2016

Thank you for your contribution. It looks good to me, but I think #31 and #33 are clearer as a solution.

@swsnider
Copy link
Contributor Author

swsnider commented Jun 6, 2016

I agree -- I'll close this one.

@swsnider swsnider closed this Jun 6, 2016
@jayconrod jayconrod mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yugui yugui

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swsnider @bazel-io @yugui @googlebot