tools/upgradedep: add support for Label based repositories.bzl#3051
Merged
linzhp merged 8 commits intobazel-contrib:masterfrom Jan 20, 2022
Merged
tools/upgradedep: add support for Label based repositories.bzl#3051linzhp merged 8 commits intobazel-contrib:masterfrom
linzhp merged 8 commits intobazel-contrib:masterfrom
Conversation
linzhp
reviewed
Jan 20, 2022
Contributor
|
The other way to test this PR is to extract the logic that reads |
Contributor
Author
|
I think reading the entire repositories file and doing a dry run of the upgrader would be a good integration test case, but that would bloat this PR, so that's a separate piece of work. |
Contributor
|
Looks good besides some mostly stylistic comments. |
blico
reviewed
Jan 20, 2022
linzhp
reviewed
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
upgradedep.go was not working due to the change to Label() based patches in #3035. Modified the parser to support both string and Label() patches.
Added tests to ensure all cases are covered for the additional code.
Which issues(s) does this PR fix?
Fixes #3050
Other notes for review