Always include debug symbols with -c dbg#3029
Merged
robfig merged 1 commit intobazel-contrib:masterfrom Dec 15, 2021
Merged
Conversation
Previously, debugging a go_test target was only possible with an explicit --@io_bazel_rules_go//go/config:debug. Fixes bazelbuild/intellij#2313.
Contributor
|
I'd normally be hesitant to add one-off rules for toggling existing flags or merge a change lacking tests, but this seems reasonable and low-risk and bazel-discuss seemed favorable towards it (https://groups.google.com/g/bazel-discuss/c/1_PC-Pj-nRg). Thanks |
saser
added a commit
to saser/pdp
that referenced
this pull request
Dec 26, 2021
This new version includes bazel-contrib/rules_go#3029 which has the effect that building a benchmark with `-c dbg` and then running with `-test.cpuprofile=<whatever>` lets `go tool pprof` see source information. This is not the case with the most recently released version of rules_go, v0.29.0. Also update Makefile so that `make buildifier` formats WORKSPACE.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Previously, debugging a
go_testtarget was only possible with an explicit--@io_bazel_rules_go//go/config:debug.Which issues(s) does this PR fix?
Fixes bazelbuild/intellij#2313, which I think is more of a
rules_goissue.