tests/core/cgo: do not assume test is being run from main repo#2956
Merged
robfig merged 1 commit intobazel-contrib:masterfrom Oct 15, 2021
siddharthab:generated_headers
Merged
tests/core/cgo: do not assume test is being run from main repo#2956robfig merged 1 commit intobazel-contrib:masterfrom siddharthab:generated_headers
robfig merged 1 commit intobazel-contrib:masterfrom
siddharthab:generated_headers
Conversation
steeve
suggested changes
Sep 24, 2021
Currently, the generated headers import paths assume that `opts_test` is being run from the main repo, but that may not be the case. When specifying include paths for header files in bazel, we generally have to specify both prefixes.
Contributor
|
This LGTM. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the generated headers import paths assume that
opts_testisbeing run from the main repo, but that may not be the case. When
specifying include paths for header files in bazel, we generally have to
specify both prefixes.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The PR is a minor enhancement to the tests such that they can be used by other projects.
Which issues(s) does this PR fix?
Fixes #2955
Other notes for review