Skip to content

Upgrade rules_cc to 7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d#2712

Closed
achew22 wants to merge 1 commit intobazel-contrib:masterfrom
achew22:rules_cc
Closed

Upgrade rules_cc to 7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d#2712
achew22 wants to merge 1 commit intobazel-contrib:masterfrom
achew22:rules_cc

Conversation

@achew22
Copy link
Copy Markdown
Member

@achew22 achew22 commented Nov 10, 2020

This is a part of bazel-contrib/bazel-gazelle#760.

To update the copy in the bazel mirror:

cd $(mktemp -d)
wget https://github.com/bazelbuild/rules_cc/archive/7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d.zip
gsutil cp 02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip gs://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip

Fixed: #2711

This is a part of bazel-contrib/bazel-gazelle#760.

To update the copy in the bazel mirror:

```
cd $(mktemp -d)
wget https://github.com/bazelbuild/rules_cc/archive/7bd0e49cfb2237086df89dca9e6ba7a5a5dfb36d.zip
gsutil cp 02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip gs://mirror.bazel.build/github.com/bazelbuild/rules_cc/archive/02becfef8bc97bda4f9bb64e153f1b0671aec4ba.zip
```

Fixed: bazel-contrib#2711
@achew22 achew22 requested a review from jayconrod as a code owner November 10, 2020 17:03
@google-cla google-cla Bot added the cla: yes label Nov 10, 2020
@achew22
Copy link
Copy Markdown
Member Author

achew22 commented Nov 10, 2020

Interestingly, it looks like the test is failing because of a minimum version issue. The missing keyword is flagged by incompatible_use_toolchain_transition which appeared in 3.4 I know you don't bump minimum versions lightly, so I wanted to just point this out and see what you thought.

@jayconrod
Copy link
Copy Markdown
Collaborator

Is it important that this update happens now? I'll update everything for the v0.25 release next month, and it's really much easier to update everything together. Gazelle should only use release versions, and I won't be able to backport this to a patch release.

@achew22
Copy link
Copy Markdown
Member Author

achew22 commented Nov 11, 2020

Is it important that this update happens now?

Sorry to make that unclear. It's totally okay to hold off on this. I was merely trying to

  1. Get an item in the release TODO list
  2. Make that item a single clock away for you

No rush. Thanks for being so prompt and wonderful 🙂

@jayconrod
Copy link
Copy Markdown
Collaborator

Cool, will hold off for now then. Thanks for working through this and for being patient. I know multi-stage changes over a long time are hard to deal with.

@UebelAndre
Copy link
Copy Markdown

With v0.25 out does that mean the cc rules were updated?

@jayconrod
Copy link
Copy Markdown
Collaborator

@UebelAndre Yes. I'll close this PR since it's superseded by #2742.

@jayconrod jayconrod closed this Dec 3, 2020
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…ntrib#2712)

The validating `py_test` generated by `compile_pip_requirements` chokes
when the source `requirements.txt` is stored read-only, such as when
managed by the Perforce Helix Core SCM. Though `dependency_resolver`
makes a temporary copy of this file, it does so w/ `shutil.copy` which
preserves the original read-only file mode. To address this, this commit
replaces `shutil.copy` with a `shutil.copyfileobj` such that the
temporary file is created w/ permissions according to the user's umask.

Resolves (bazel-contrib#2608).

---------

Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update rules_cc to

3 participants