Skip to content

Revert "add importpath_aliases to go_proto_library (#2608)" #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jayconrod wants to merge 1 commit into from
Closed

Revert "add importpath_aliases to go_proto_library (#2608)" #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion proto/def.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ go_proto_library = go_rule(
),
"importpath": attr.string(),
"importmap": attr.string(),
"importpath_aliases": attr.string_list(), # experimental, undocumented
"embed": attr.label_list(providers = [GoLibrary]),
"gc_goopts": attr.string_list(),
"compiler": attr.label(providers = [GoProtoCompiler]),
Expand Down
7 changes: 0 additions & 7 deletions tests/core/go_proto_library/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,9 @@ go_test(
deps = [":protos_go_proto"],
)

go_test(
name = "protos_alias_test",
srcs = ["protos_alias_test.go"],
deps = [":protos_go_proto"],
)

go_proto_library(
name = "protos_go_proto",
importpath = "github.com/bazelbuild/rules_go/tests/core/go_proto_library/protos",
importpath_aliases = ["myalias/protos"],
protos = [
":protos_a_proto",
":protos_b_proto",
Expand Down
6 changes: 0 additions & 6 deletions tests/core/go_proto_library/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,3 @@ wkt_wrapper_test
Checks that most of the well known types in ``//proto/wkt`` are wrappers
for packages in ``@org_golang_google_protobuf``. The proto types should be
type aliases.

protos_alias_test
-----------------

Checks that packages generated by `go_proto_library` can be imported using one of the strings
listed in ``importpath_aliases``.
29 changes: 0 additions & 29 deletions tests/core/go_proto_library/protos_alias_test.go
View file
Open in desktop

This file was deleted.