Skip to content

Windows: Use actions.run and explicitly format cmd.exe .bat invocation #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunjayBhatia wants to merge 1 commit into from
Closed

Windows: Use actions.run and explicitly format cmd.exe .bat invocation #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions go/private/rules/binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ def _go_tool_binary_impl(ctx):
content = cmd,
)
ctx.actions.run(
executable = bat,
inputs = sdk.libs + sdk.headers + sdk.tools + ctx.files.srcs + [sdk.go],
executable = "cmd.exe",
arguments = ["/S", "/C", bat.path.replace("/", "\\")],
inputs = sdk.libs + sdk.headers + sdk.tools + ctx.files.srcs + [sdk.go, bat],
outputs = [cout],
env = {"GOROOT": sdk.root_file.dirname}, # NOTE(#2005): avoid realpath in sandbox
mnemonic = "GoToolchainBinaryCompile",
Expand Down