Add missing Starlark files to “all_rules” targets.#2434
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Apr 16, 2020
Merged
Add missing Starlark files to “all_rules” targets.#2434jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
This is important for Stardoc, which insists on knowing about all transitively loaded Starlark files.
jayconrod
approved these changes
Apr 16, 2020
Collaborator
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
jayconrod
pushed a commit
that referenced
this pull request
Jul 8, 2020
This is important for Stardoc, which insists on knowing about all transitively loaded Starlark files.
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
This will remove the merge conflicts and improve the usability when the `MODULE.bazel.lock` is used together with `rules_python`. This means that the lock file will not be used to read the `URL` and `sha256` values for the Python sources when the `experimental_index_url` is used, but the idea is that that information will be kept in repo cache. Fixes bazel-contrib#2434 Created bazel-contrib#2731 to leverage the bazel feature to write immutable facts to the lock file once it becomes available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important for Stardoc, which insists on knowing about all transitively
loaded Starlark files.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
When generating documentation for a rule that uses these rules using Stardoc,
compilation currently fails because not all transitively loaded files are present.
Which issues(s) does this PR fix?
Fixes #
Other notes for review