Delete legacy cgo code path#2218
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Sep 13, 2019
Merged
Conversation
Since the GoCompilePkg action now supports building archives with cgo code in a single action, there's no need for the legacy cgo path, which created a nest of rules for each library with cgo = True. This legacy path has been removed to simplify maintenance. As a result, setting 'objc = True' is now an error. Objective C files should either be included in srcs (they can be built with GoCompilePkg) or extracted into a separate objc_library and listed in cdeps. Additionally, the cgo_archives field of GoSource has been removed, since it's not used by GoCompilePkg. Updates bazel-contrib#2170
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…rib#2218) This `semver` function may turn out to be useful in validating the input for the `python.*override` tag classes to be added in a followup PR. Because this is a refactor of an existing code and adding tests, I decided to split it out. For a POC see bazel-contrib#2151, work towards bazel-contrib#2081.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the GoCompilePkg action now supports building archives with cgo
code in a single action, there's no need for the legacy cgo path,
which created a nest of rules for each library with cgo = True. This
legacy path has been removed to simplify maintenance.
As a result, setting 'objc = True' is now an error. Objective C files
should either be included in srcs (they can be built with
GoCompilePkg) or extracted into a separate objc_library and listed in
cdeps.
Additionally, the cgo_archives field of GoSource has been removed,
since it's not used by GoCompilePkg.
Updates #2170