Update cross compile instructions when using cgo#2204
Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom Sep 10, 2019
Merged
Update cross compile instructions when using cgo#2204jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod merged 2 commits intobazel-contrib:masterfrom
Conversation
This was noted in the release notes for 0.19.0: https://github.com/bazelbuild/rules_go/releases/tag/0.19.0, but hard to find anywhere else.
jayconrod
approved these changes
Sep 10, 2019
Collaborator
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Thanks! sorry for the delay.
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
With this PR we get rudimentary unit tests for the `python` bzlmod extension which allows us to unit test the override behaviour that will become more complex soon. Summary: - refactor: inline the python_register_toolchains - refactor: use toolchain_info to call python_register_toolchains - refactor: move the registration out of the main loop - refactor: split the parsing of the modules to a separate function - test(bzlmod): add python.toolchain module parsing tests Work towards bazel-contrib#2081 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was noted in the release notes for 0.19.0: https://github.com/bazelbuild/rules_go/releases/tag/0.19.0, but hard to find anywhere else.