Fix vendored Skylib w/ Windows-native test wrapper#2082
Closed
laszlocsomor wants to merge 1 commit intobazel-contrib:masterfrom
Closed
Fix vendored Skylib w/ Windows-native test wrapper#2082laszlocsomor wants to merge 1 commit intobazel-contrib:masterfrom
laszlocsomor wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
Partially back-port Skylib's daf513702286fe211f291675443235e35e79f34f to the vendored Skylib code, to fix unittest.bzl for Bazel's native test wrapper on Windows. The native test wrapper will replace the Bash-script test wrapper on Windows. See bazelbuild/bazel#6622 I tried updating the current Skylib 0.5.0 sources to 0.8.0, but tests failed on Travis CI, probably because an older Bazel version is used. Details are in "go/private/skylib/README.rst".
laszlocsomor
changed the title
Contributor
Author
|
Tests look good \o/ |
Collaborator
|
Thanks for fixing this, but I ended up removing the vendored copy of Skylib in #2083 instead. There is a set of files loaded from Everything not loaded from |
Contributor
Author
|
Cool, thanks! |
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…#2082) This is to unify how it handles printing log messages. This also updates repo rules using repo_utils to create loggers and set the `_rule_name` attribute for the logger to use. * Also removes defunct repo_utils.debug_print * Also makes some functions private that aren't used elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially back-port a Skylib commit [1] to the
vendored Skylib code, to fix unittest.bzl for
Bazel's native test wrapper on Windows.
The native test wrapper will replace the
Bash-script test wrapper on Windows [2].
I tried updating the current Skylib 0.5.0 sources
to 0.8.0, but tests failed on Travis CI. I suspect
that an older Bazel version is used.
[1] bazelbuild/bazel-skylib@daf5137
[2] bazelbuild/bazel#6622