Update dependencies#1974
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Mar 3, 2019
Merged
Conversation
Also: * Add sanitize_patch_dates.sh which should reduce diffs in patches in the future, making them easier to review. * Set analysis.Pass.TypesSizes in nogo. This is needed for the new atomicalign analyzer.
blico
pushed a commit
to blico/rules_go
that referenced
this pull request
May 10, 2019
Also: * Add sanitize_patch_dates.sh which should reduce diffs in patches in the future, making them easier to review. * Set analysis.Pass.TypesSizes in nogo. This is needed for the new atomicalign analyzer.
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…el-contrib#1974) Remove the `python_version` from `flag_values` and reduces the number of targets we create by a lot because we no longer need to create all of the micro version combinations to also match when we want to match e.g. 3.10 on a particular platform by using a trick I've learned in bazel-contrib#1968: ```starlark select({ "is_python_3.x": "my_config_setting" "//conditions:default": "is_python_3.x" }) ``` Then further optimization was done on how we create the aliases and config settings and optimizing the usage of `pip_whl` flag finally reduced the internal number targets. The number config settings targets in `//tests/private/pip_config_settings/...` where we have multiple python versions has changed: * `:is_*` - from **995** to **996** (the extra addition being is_python_default). * `:_.*is_*` - from **28272** to **2480** (just python version) and then to **496** (final). Work towards bazel-contrib#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
the future, making them easier to review.
atomicalign analyzer.