Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @go_googleapis in go_rules_dependencies() #1581

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

jayconrod
Copy link
Contributor

@go_googleapis contains proto_library and go_proto_library rules for
github.com/googleapis/googleapis. It's best to have a standard place
for these to avoid conflicts, especially widely used generic protos
like google/rpc/status.proto.

Also added a test that uses gRPC and libraries from @go_googleapis

Related #1548

Jay Conrod added 2 commits July 2, 2018 12:58
@go_googleapis contains proto_library and go_proto_library rules for
github.com/googleapis/googleapis. It's best to have a standard place
for these to avoid conflicts, especially widely used generic protos
like google/rpc/status.proto.

Related bazel-contrib#1548
@jayconrod jayconrod requested a review from ianthehat July 2, 2018 18:37
@jayconrod jayconrod merged commit 9ff93c2 into bazel-contrib:master Jul 3, 2018
@jayconrod jayconrod deleted the go_googleapis branch July 3, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants