Replace WKT go_library rules with aliases to //proto/wkt #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a significant number of existing rules that depend on WKT go_library rules directly (for example, @com_github_golang_protobuf//ptypes/any:go_default_library). Gazelle resolves now Go imports to @io_bazel_rules_go//proto/wkt, so it's very easy to end up with conflicting dependencies. With this change, WKT go_library rules are replaced with aliases pointing to the equivalent @io_bazel_rules_go//proto/wkt rules. protoc-gen-go itself depends on descriptor and plugin, so two bootstrap go_library rules are introduced, visible only to protoc-gen-go. Related bazel-contrib/bazel-gazelle#159
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
Jul 3, 2018
…el-contrib#1498)" This reverts commit ca213b3.
jayconrod
added a commit
that referenced
this pull request
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a significant number of existing rules that depend on WKT
go_library rules directly (for example,
@com_github_golang_protobuf//ptypes/any:go_default_library). Gazelle
resolves now Go imports to @io_bazel_rules_go//proto/wkt, so it's very
easy to end up with conflicting dependencies.
With this change, WKT go_library rules are replaced with aliases
pointing to the equivalent @io_bazel_rules_go//proto/wkt rules.
protoc-gen-go itself depends on descriptor and plugin, so two
bootstrap go_library rules are introduced, visible only to
protoc-gen-go.
Related bazel-contrib/bazel-gazelle#159