-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: deprecate the go_rule wrapper #2302
Comments
This is a workaround for a visibility issue, possibly introduced by the --incompatible_remap_main_repo flag or something similar. We should stop using go_rule though. Fixes bazel-contrib#676 Updates bazel-contrib/rules_go#2302
This is a workaround for a visibility issue, possibly introduced by the --incompatible_remap_main_repo flag or something similar. We should stop using go_rule though. Fixes #676 Updates bazel-contrib/rules_go#2302
I see the deprecation commit made it in and would love to hear what the migration should look like! (bazel_gomock is still using |
@jmhodges I apologize for creating a classic Google "old thing is deprecated, new thing is not ready yet" dilemma. I thought it was important to mark this is deprecated, given that there are potential problems caused by Bazel. The change I would like to make is for a skeleton Go rule to look something like this:
The rule would get nearly all of the information it needs from the toolchain. There are a few things that must be configured for the target platform (C toolchain, flags), and toolchains are always configured for the host platform, so we still need After this is ready and |
This changes how the goos, goarch, race, msan, static, and pure attributes of go_binary and go_test are implemented. Previously, the go_binary and go_test rules used an aspect on the deps and embed attributes. If any of the mode attributes listed above were set, the aspect declared additional output files and actions to generate them for the specified configuration. This approach had two significant problems. First, the aspect caused the analysis to be performed twice, wasting time and memory even in the case where no cross-compilation was needed. Second, the aspect was not compatible with conditional dependencies specified with select expressions: aspects run on the configured target graph, but the mode attributes could not affect Bazel's configuration. This change deletes the aspect and implements these attributes using a different mechanism: build settings and configuration transitions. A new package is added //go/config with a build setting for each attribute. Most settings are flags that may be set on the command-line. This is an alternative to --feature flags, which will be deprecated and eventually removed. The target //:go_config gathers build settings relevant to Go and provides a GoContextInfo (private). The target //:go_context_data depends on //:go_config, //:stdlib, //:nogo, and a few other standard dependencies. go_binary and go_test rules no longer need to depend on these targets directly. Go rules should now only need to depend on //:go_context_data and the Go toolchain. Unfortunately, neither //:go_context_data nor //:go_config can be part of the toolchain because the toolchain is always analyzed for the execution configuration, not the target configuration. Because of the simplified dependencies, the go_rule function is no longer needed by most rules. This change makes it possible to deprecate it. Fixes #1351 Fixes #2219 Updates #2302
This changes how the goos, goarch, race, msan, static, and pure attributes of go_binary and go_test are implemented. Previously, the go_binary and go_test rules used an aspect on the deps and embed attributes. If any of the mode attributes listed above were set, the aspect declared additional output files and actions to generate them for the specified configuration. This approach had two significant problems. First, the aspect caused the analysis to be performed twice, wasting time and memory even in the case where no cross-compilation was needed. Second, the aspect was not compatible with conditional dependencies specified with select expressions: aspects run on the configured target graph, but the mode attributes could not affect Bazel's configuration. This change deletes the aspect and implements these attributes using a different mechanism: build settings and configuration transitions. A new package is added //go/config with a build setting for each attribute. Most settings are flags that may be set on the command-line. This is an alternative to --feature flags, which will be deprecated and eventually removed. The target //:go_config gathers build settings relevant to Go and provides a GoContextInfo (private). The target //:go_context_data depends on //:go_config, //:stdlib, //:nogo, and a few other standard dependencies. go_binary and go_test rules no longer need to depend on these targets directly. Go rules should now only need to depend on //:go_context_data and the Go toolchain. Unfortunately, neither //:go_context_data nor //:go_config can be part of the toolchain because the toolchain is always analyzed for the execution configuration, not the target configuration. Because of the simplified dependencies, the go_rule function is no longer needed by most rules. This change makes it possible to deprecate it. Fixes #1351 Fixes #2219 Updates #2302
See bazel-contrib/bazel-gazelle#676.
A Bazel incompatibility flag (possibly
--incompatible_remap_main_repo
, see bazelbuild/bazel#7130) causes default labels in attributes to be resolved in@io_bazel_rules_go//go/private
(wherego_rule
is defined) instead of wherever the rule should actually have been defined.We use
go_rule
as a wrapper aroundrule
to add hidden attributes and a toolchain dependency. Instead, we should move hidden attributes to the toolchain or provide a set of common attributes. The toolchain dependency can be explicit.The text was updated successfully, but these errors were encountered: