Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and verify GCC compatibility #177

Merged
merged 7 commits into from
Sep 2, 2021
Merged

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Aug 16, 2021

Fixes #176.

Makes it easier to skip targets, such as those using FuzzedDataProvider
when using gcc as CC.
Using the weak attribute together with an explicitly undefined symbol
should still work on macOS, see:
https://stackoverflow.com/a/34983229/297261
README.md Outdated Show resolved Hide resolved
BUILD Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fuzzing/replay/replay_main.cc Show resolved Hide resolved
BUILD Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fuzzing/replay/replay_main.cc Show resolved Hide resolved
@fmeum fmeum force-pushed the gcc branch 4 times, most recently from 8c46709 to 0eba32d Compare August 22, 2021 18:20
@fmeum
Copy link
Member Author

fmeum commented Aug 23, 2021

@stefanbucur The CI is broken due to a regression in Bazel 4.2.0 which came out a few days ago and is now used by both OSS-Fuzz and the Bazel tests. Don't worry, projects using rules_fuzzing do not seem to be affected.

@fmeum
Copy link
Member Author

fmeum commented Aug 23, 2021

There will be a 4.2.1 release that fixes the regression, see bazelbuild/bazel#13890.

@stefanbucur Could you as the maintainer follow the instructions at bazelbuild/bazel#13890 (comment) to add rules_fuzzing to the Bazel release CI? Let me know if I can be of help.

.github/workflows/bazel_test.yml Outdated Show resolved Hide resolved
@fmeum
Copy link
Member Author

fmeum commented Sep 1, 2021

Now that Bazel 4.2.1, the pipeline passes.

I had to exclude the Java regression tests from the macOS regression test for now, but will enable them once I have understood where to find the required dylibs. All regression tests are now buildable and runnable with gcc and C++ tests are also compatible with macOS.

Excludes the tests in //examples/java, which require further fixes to
find libjvm.dylib.
Implements the missing readlink -f command in Python.
@stefanbucur stefanbucur merged commit e409c0c into bazel-contrib:master Sep 2, 2021
haberman added a commit to haberman/upb that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cc_fuzz_test() breaks non-Clang builds
2 participants