Fix cross compiling for android on macOS #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/fix-cross-compiling-for-android-on-macos
branch
from
215bae4
to
b2b81f0
Compare
keith
commented
Jan 6, 2023
| @@ -209,6 +209,7 @@ CC_EXTERNAL_RULE_ATTRIBUTES = { | |||
| cfg = "exec", | |||
| default = [], | |||
| ), | |||
| "_android_constraint": attr.label(default = Label("@platforms//os:android")), | |||
There was a problem hiding this comment.
I chose to only add this one for now since it's a bit of boilerplate to add more, but I can if folks want to
The way rules_foreign_cc builds cross compilation targets isn't exactly what cmake expects. Because of this when targeting android on macOS, some macOS specific linker flags are added to cmake's test compile invocations, leading to failures. This works around this issue by setting some more variables to trick cmake into only using the expected settings.
keith
force-pushed
the
ks/fix-cross-compiling-for-android-on-macos
branch
from
b2b81f0
to
0258fce
Compare
jsharpe
approved these changes
Feb 22, 2023
jungleraptor
added a commit
to jungleraptor/rules_foreign_cc
that referenced
this pull request
Jun 19, 2023
Same as bazel-contrib#997 but for linux instead of android.
jsharpe
pushed a commit
that referenced
this pull request
Jun 27, 2023
Fixes cross-compiling from macos to linux. see #997 for background. I had to make a couple of extra changes to support this: Setting CMAKE_SYSTEM_NAME manually causes CMAKE_SYSTEM_PROCESSOR to not be set. This breaks some builds that expect this variable to be set like libjpeg-turbo. I made it so that the above variables are only set when cross-compilation is detected so that rules_foreign_cc only takes on responsibility of setting them when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way rules_foreign_cc builds cross compilation targets isn't exactly what cmake expects. Because of this when targeting android on macOS, some macOS specific linker flags are added to cmake's test compile invocations, leading to failures. This works around this issue by setting some more variables to trick cmake into only using the expected settings.
Fixes #289