Update cmake and ninja versions #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
force-pushed
the
cmake_ninja_versions
branch
3 times, most recently
from
7031ac6
to
a5b4e89
Compare
jsharpe
force-pushed
the
cmake_ninja_versions
branch
from
a5b4e89
to
7003007
Compare
UebelAndre
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Nice!
The failures seem to be the same issues as bazelbuild/rules_rust#1814 which is unfortunate. Not sure if a Googler has looked into it yet but the PR otherwise seems good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the python script to autogenerate the shas for the source files for cmake.