Add toolchain executables to the PATH #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheaff1
force-pushed
the
add_tools_to_path
branch
4 times, most recently
from
e0bdced
to
934fba7
Compare
Previously, some toolchain executables, e.g. make, pkg-config etc. were not added to the PATH correctly. As such, even if make and pkg-config were built from source, the system executables were used. This commit modifies the tools_files attribute of the rules_foreign_cc framework to instead be "tools_data", which provides path to the executable and the target that provides it.
jheaff1
force-pushed
the
add_tools_to_path
branch
from
934fba7
to
0a243b4
Compare
Merged
|
@jsharpe @UebelAndre Any chance of a review? 😄 |
Its on my todo list to take a look at this! |
jsharpe
approved these changes
Dec 10, 2022
|
Apologies for the delay in reviewing this! |
No worries, thanks for taking the time to review it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some toolchain executables, e.g. make, pkg-config etc. were not added to the PATH correctly. As such, even if make and pkg-config were built from source, the system executables were used.
This commit modifies the tools_files attribute of the rules_foreign_cc framework to instead be "tools_data", which provides path to the executable and the target that provides it.