Fix current toolchains #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheaff1
force-pushed
the
fix_current_toolchains
branch
2 times, most recently
from
18066f0
to
296eb00
Compare
The "Make Variables" defined for the current_*_toolchains contained "$EXT_BUILD_ROOT/" in the path to the tool. As the current_*_toolchains are intended to be used in non foreign_cc rules, EXT_BUILD_ROOT is undefined and the tool path is incorrect. This commit resolves this issue and adds a test to CI
jheaff1
force-pushed
the
fix_current_toolchains
branch
from
296eb00
to
2b402c3
Compare
jsharpe
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for more info