Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial bzlmod support #839

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Initial bzlmod support #839

merged 1 commit into from
Jan 1, 2022

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Dec 17, 2021

Initial changes required to support bzlmod.

abrisco
abrisco approved these changes Dec 19, 2021
View reviewed changes
Copy link

@abrisco abrisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions but otherwise seems good to me 👍

toolchains/built_toolchains.bzl Outdated Show resolved Hide resolved
foreign_cc/repositories.bzl Show resolved Hide resolved
UebelAndre
UebelAndre approved these changes Dec 19, 2021
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

toolchains/built_toolchains.bzl Outdated Show resolved Hide resolved
toolchains/built_toolchains.bzl Outdated Show resolved Hide resolved
toolchains/built_toolchains.bzl Outdated Show resolved Hide resolved
toolchains/prebuilt_toolchains.py Outdated Show resolved Hide resolved
@jsharpe jsharpe enabled auto-merge (squash) January 1, 2022 21:06
@jsharpe jsharpe merged commit 3c14ef4 into bazel-contrib:main Jan 1, 2022
@jsharpe jsharpe mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrisco abrisco abrisco approved these changes

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsharpe @UebelAndre @abrisco