Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let make build in BUILD_TMPDIR #818

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Let make build in BUILD_TMPDIR #818

merged 1 commit into from
Nov 24, 2021

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Nov 20, 2021 •
edited
Loading

configure_make already used BUILD_TMPDIR whereas make did not.

Fixes #797.

@fmeum
Let make build in BUILD_TMPDIR
d11182d 
configure_make already used BUILD_TMPDIR whereas make did not.
@fmeum fmeum marked this pull request as ready for review November 20, 2021 10:44
jsharpe
jsharpe approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsharpe jsharpe enabled auto-merge (squash) November 24, 2021 23:24
@jsharpe jsharpe merged commit 1a262c9 into bazel-contrib:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make builds fail to land in $$BUILD_TMPDIR$$
2 participants
@fmeum @jsharpe