Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MAKE env var #638

Merged
merged 3 commits into from
May 9, 2021
Merged

Set MAKE env var #638

merged 3 commits into from
May 9, 2021

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented May 9, 2021

Rework of patch in #549. Fixes #590.

@jsharpe jsharpe requested a review from UebelAndre May 9, 2021 22:03
@jsharpe jsharpe requested a review from oquenchil as a code owner May 9, 2021 22:03
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine change but I wonder if we could solve for the same thing by fixing the way we inject things into PATH. Would that solve for the same thing?

foreign_cc/private/configure_script.bzl Outdated Show resolved Hide resolved
@jsharpe
Copy link
Member Author

jsharpe commented May 9, 2021

I think this is a fine change but I wonder if we could solve for the same thing by fixing the way we inject things into PATH. Would that solve for the same thing?

No, because that would rely on the tool in the make toolchain being called "make" whereas setting the MAKE environment variable allows tools to be named differently e.g. gmake is a common name for installing GNUMake on systems that have BSD make under the name make

@google-cla
Copy link

google-cla bot commented May 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented May 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@UebelAndre
Copy link
Collaborator

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@UebelAndre
Copy link
Collaborator

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 9, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@UebelAndre
Copy link
Collaborator

I'm not sure what's up with CLA but @jsharpe and I have definitely signed it.

@UebelAndre UebelAndre merged commit cef5ee6 into bazel-contrib:main May 9, 2021
@jsharpe jsharpe deleted the make_env branch August 3, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built make tool does not get put into $PATH for configure_make() projects
2 participants