Fixed cmake build and target arguments #573
Conversation
| # Pass arguments to the underlying build tool | ||
| "--", | ||
| "-j 1", |
There was a problem hiding this comment.
Are we better demonstrating --parallel here: https://stackoverflow.com/a/50883540/6857772 or https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html? Feels like a more portable way of doing this.
There was a problem hiding this comment.
My goal here wasn't strictly to demonstrate parallel builds. I just wanted to show how to pass arguments to the build tool
https://cmake.org/cmake/help/latest/command/build_command.html
note the -- -i
There was a problem hiding this comment.
I've updated the example to hopefully make this clearer
| @@ -48,6 +48,7 @@ tasks: | |||
| - "-//cmake_defines/..." | |||
| - "-//cmake_hello_world_lib/..." | |||
| - "-//cmake_with_data/..." | |||
| - "-//cmake_with_target/..." | |||
There was a problem hiding this comment.
If we defaulted to ninja then these would work on RBE...
There was a problem hiding this comment.
I'd rather spend next release getting RBE to work (build the make binary)
Targets can now be properly passed to the CMake build command and arguments are now appropriately the last thing to be passed to provide the most flexibility.