RBE make #548
Merged
RBE make #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
force-pushed
the
rbe_make
branch
2 times, most recently
from
3819ab1 to
00f83ff
Compare
UebelAndre
requested changes
Mar 27, 2021
foreign_cc/cmake.bzl
Outdated
| @@ -197,6 +195,13 @@ def _get_generator_target(ctx): | |||
| else: | |||
| fail("No generator set and no default is known. Please set the cmake `generator` attribute") | |||
|
|
|||
| if "Unix Makefiles" == generator: | |||
There was a problem hiding this comment.
I feel like this is unnecessary and you just append the generator args in the _cmake_impl macro. Either that or move allow this macro to also return tool_deps or something so there's only one where we check generator info. I think I prefer the latter
There was a problem hiding this comment.
Good shout that's a better idea than this, it didn't seem right when I added it.
|
Also, I think this would warrant a patch release for the CMake stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.