Apply expand_locations_and_make_variables to cache_entries #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-sm
pushed a commit
to matt-sm/rules_foreign_cc
that referenced
this pull request
Aug 5, 2024
|
Apologies for having to revert this @froody - I should have checked CI, but the already broken state meant that I missed the failures this introduced. Feel free to resubmit this as I should soon have CI back to a green state again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building proj I need to pass the sqlite3 binary via a cache entry, like
{"EXE_SQLITE3": "$(execpath @sqlite3//:shell)"}but that requires that cache entries are also expanded.