Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase resiliency of runnable_binary #1134

Merged
merged 13 commits into from
Feb 1, 2024
Merged

Increase resiliency of runnable_binary #1134

merged 13 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. Allow using runnable_binary on targets with no shared libraries

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d6aee61 View commit details
    Browse the repository at this point in the history

  2. Try to get rid of warning via default expansion

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7df69ca View commit details
    Browse the repository at this point in the history

  3. Switch approach to checking if arrays are defined

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    805afd4 View commit details
    Browse the repository at this point in the history

  4. Get rid of second check, fix typos in docs 

    The second check can never be false if the first one is true
    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    962ec61 View commit details
    Browse the repository at this point in the history

  5. Fix it to work on mac maybe 

    Mac uses a pretty old bash. So we:
1) don't use newer bash commands like -v
2) unconditionally declare all arrays
3) just check if they're empty instead
    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0fe9520 View commit details
    Browse the repository at this point in the history

  6. Ensure that RUNFILES_DIR exists before cd'ing into it

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b6fb026 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a89b93c View commit details
    Browse the repository at this point in the history

  8. Do not set RUNFILES_DIR to non existent directory

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0f175ac View commit details
    Browse the repository at this point in the history

  9. Unconditionally cd into the previous directory

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5041bb3 View commit details
    Browse the repository at this point in the history

  10. Remove special case for --run_under 

    This commit removes the special case for `--run_under` which tried to
find a runfile directory beside the currently executing script. This
isn't needed because the runfiles bash script should set RUNFILES_DIR
to the right thing anyway
    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a91d7ca View commit details
    Browse the repository at this point in the history

  11. Error on bad RUNFILES_DIR and set RUNFILES_DIR to abs path

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    dc6d1eb View commit details
    Browse the repository at this point in the history

  12. Use cross platform method of getting absolute path

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a677af5 View commit details
    Browse the repository at this point in the history

  13. Fix abs path method

    @mishazharov
    mishazharov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1b22e4f View commit details
    Browse the repository at this point in the history