Set the LD environment variable #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
added a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Jan 20, 2024
This reverts commit c62e551.
jsharpe
added a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Sep 5, 2024
This reverts commit c62e551.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some configure + make systems look for the
ldbinary that is supposed to be used, and invoke it directly for various reasons.Currently this uses the
ldbinary from$PATH, not from the toolchain, so we set theLDenvironment variable to ensure that we're using theldbinary.Note: This grabs the
ldexecutable directly fromcc_toolchain.ld_executablerather than using something likecxx_linker_executable, because the former returnsCCgenerally, butLDshould be the linker directly.