Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new darwin CC toolchain for tests #1017

Merged

Conversation

keith
Copy link
Member

@keith keith commented Feb 22, 2023

Bazel 7.x is going to remove the CC toolchain that supports iOS and use the unix toolchain for macOS support. Since there are some tests that use the iOS toolchain we need to set that up for testing.

@jsharpe
Copy link
Member

jsharpe commented Feb 27, 2023

@keith it seems the version of build_bazel_apple_support unconditionally uses module_extension which doesn't work on 4.0 which is the current minimum supported version for this ruleset. Is there some way we can conditionally load this based on bazel version?

@keith
Copy link
Member Author

keith commented Feb 28, 2023

hrm. it sounds like maybe i could move this into a different file, but that might require users have to change their load statements. given that bazel doesn't support 4.x any more do you know when this repo might drop that compat as well?

@jsharpe
Copy link
Member

jsharpe commented Feb 28, 2023

hrm. it sounds like maybe i could move this into a different file, but that might require users have to change their load statements. given that bazel doesn't support 4.x any more do you know when this repo might drop that compat as well?

https://blog.bazel.build/2020/11/10/long-term-support-release.html - this timeline suggests that 4.x is still LTS until Dec 2023 unless you know of a different timeline that says otherwise?

@keith
Copy link
Member Author

keith commented Feb 28, 2023

oh interesting. i just recently saw some comments about how another 5.x release wasn't going to be cut, which made me assume that was also considered not very well supported anymore, but I guess not

Bazel 7.x is going to remove the CC toolchain that supports iOS and use
the unix toolchain for macOS support. Since there are some tests that
use the iOS toolchain we need to set that up for testing.
@keith keith force-pushed the ks/add-new-darwin-cc-toolchain-for-tests branch from ffb924a to dd1833a Compare March 3, 2023 22:10
@keith
Copy link
Member Author

keith commented Mar 3, 2023

I added a patch here to just toss that from apple_support, should work for the short term

@jsharpe jsharpe enabled auto-merge (squash) March 4, 2023 11:55
@jsharpe jsharpe merged commit d33d862 into bazel-contrib:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants