Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hermetic bsdtar linux toolchain #611

Closed
wants to merge 1 commit into from

Conversation

thesayyn
Copy link
Collaborator

Now that linux toolchain for bsdtar linux_{amd64,arm64} includes all the libraries, every feature of it should work independently from host.

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • Covered by existing test cases

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be a draft until we have a way to generate the file?

@alexeagle alexeagle changed the base branch from 2.x to main October 20, 2023 00:03
@alexeagle
Copy link
Collaborator

@thesayyn now that we also fetch the correct libc, is there anything remaining that's non-hermetic?

@betaboon
Copy link

betaboon commented Nov 6, 2023

i think the approach of using the ftp-urls here is very error-prone.
e.g. https://ftp.debian.org/debian/pool/main/g/glibc/libc6_2.36-9+deb12u1_amd64.deb already returns 404 today.

similar discussion in bazel-contrib/rules_oci#375

@thesayyn
Copy link
Collaborator Author

thesayyn commented Nov 6, 2023

i think the approach of using the ftp-urls here is very error-prone. e.g. https://ftp.debian.org/debian/pool/main/g/glibc/libc6_2.36-9+deb12u1_amd64.deb already returns 404 today.

similar discussion in bazel-contrib/rules_oci#375

yeah, that's why I abandoned this approach.

@betaboon
Copy link

betaboon commented Nov 6, 2023

i think the approach of using the ftp-urls here is very error-prone. e.g. https://ftp.debian.org/debian/pool/main/g/glibc/libc6_2.36-9+deb12u1_amd64.deb already returns 404 today.
similar discussion in bazel-contrib/rules_oci#375

yeah, that's why I abandoned this approach.

ah lol. sorry didn't put your username in this PR and the other issue together 🤦

@thesayyn
Copy link
Collaborator Author

thesayyn commented Nov 6, 2023

@thesayyn now that we also fetch the correct libc, is there anything remaining that's non-hermetic?

This is not gonna work due to rolling updates trait of debian repos

@alexeagle
Copy link
Collaborator

I posted to bazel slack #general channel to see if anyone has a great answer for stable .deb fetches across the bazel ecosystem

@alexeagle
Copy link
Collaborator

replaced by #804

@alexeagle alexeagle closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants