Added bzl_library targets for use in external repos using stardoc#936
Closed
UebelAndre wants to merge 1 commit intobazel-contrib:masterfrom
UebelAndre:stardoc
Closed
Added bzl_library targets for use in external repos using stardoc#936UebelAndre wants to merge 1 commit intobazel-contrib:masterfrom UebelAndre:stardoc
UebelAndre wants to merge 1 commit intobazel-contrib:masterfrom
UebelAndre:stardoc
Conversation
Contributor
|
Sorry, I'd rather not merge this. It's a duplicate of #760. I'll comment on that one. |
Author
|
@jayconrod Why would you close this PR (one that works) in favor of an older one that's had no activity for months? |
Contributor
|
This one isn't correct either. At a quick glance, it adds a duplicate dependency in |
Author
|
Ultimately I don't care which PR gets merged but I disagree with closing this over an inactive PR. Hopefully #760 gets merged soon though 🤞. Thanks for taking a look 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
other
What does this PR do? Why is it needed?
This PR exposes
bzl_librarytargets.Which issues(s) does this PR fix?
This fixes the ability to use
stardocin other projects that depend onbazel-gazelleOther notes for review
This implements the same thing as #760 but with a fix for the visibility of the top level
//:bzl_srcstarget so it can actually be used in other projects.Also, I'm unsure if bazel-contrib/rules_go#2621 can be applied to this repo as well.