gazelle_binary: remove mode attributes#882
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Aug 26, 2020
Merged
Conversation
This PR removes mode attributes (goos, goarch, race, etc.) from the gazelle_binary rule. These attributes were implemented using private files in rules_go, so supporting them is blocking changes in the rules_go implementation. These attributes should probably never be used. gazelle_binary should generally be built for the host configuration (by 'bazel run' or 'bazel build' without configuration flags). If a binary is still needed in a different configuration, that may still be accomplished with command-line flags like --platforms or --@io_bazel_rules_go//go/config:race. Fixes bazel-contrib#803
Member
|
With this submitted (and thank you so much for doing it!) I believe we can land bazel-contrib/rules_go#2621 if you tag a new release. I will update the PR to reflect that change if you're willing to do a new Gazelle release. |
Contributor
Author
|
I'm planning to tag rules_go and Gazelle releases today. That should unblock the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes mode attributes (goos, goarch, race, etc.) from the
gazelle_binary rule. These attributes were implemented using private
files in rules_go, so supporting them is blocking changes in the
rules_go implementation.
These attributes should probably never be used. gazelle_binary should
generally be built for the host configuration (by 'bazel run' or
'bazel build' without configuration flags). If a binary is still
needed in a different configuration, that may still be accomplished
with command-line flags like --platforms or
--@io_bazel_rules_go//go/config:race.
Fixes #803