Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when additional metadata isn't available in the first frames #677

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

JeromeMartinez
Copy link
Contributor

e.g. crash with cropdetect filter and several other filters, but could also be wrong metadata in some other corner cases).

Fix #674.

Test build.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
e.g. with cropdetect filter

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@dericed
Copy link
Member

dericed commented Nov 2, 2020

seems ok at resolving the issue. could you elaborate on "could also be wrong metadata"?

@JeromeMartinez
Copy link
Contributor Author

could you elaborate on "could also be wrong metadata"?

In theory, metadata may be not assigned to the right frame instead of crashing.

@dericed
Copy link
Member

dericed commented Nov 2, 2020

I have a sample file with cropdetect data from this for each frame:

            <tag key="lavfi.cropdetect.x1" value="0.000000"/>
            <tag key="lavfi.cropdetect.x2" value="320.000000"/>
            <tag key="lavfi.cropdetect.y1" value="0.000000"/>
            <tag key="lavfi.cropdetect.y2" value="240.000000"/>
            <tag key="lavfi.cropdetect.w" value="320.000000"/>
            <tag key="lavfi.cropdetect.h" value="240.000000"/>
            <tag key="lavfi.cropdetect.x" value="0"/>
            <tag key="lavfi.cropdetect.y" value="0"/>

but the plots for x1,x2 and for y1,y2 are with a y-axis of 0-1, although item defines the range as 0-nullptr. In mouse-over preview the values are only either 0 or 1. The plot for x,y has no y-axis at all.

@dericed
Copy link
Member

dericed commented Nov 2, 2020

image

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@dericed dericed merged commit 0399827 into bavc:master Nov 3, 2020
@g-maxime g-maxime deleted the additionalstats branch December 30, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest build crashes when cropdetect is selected
3 participants