Initial commit on compatible API #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jhon Honce <jhonce@redhat.com>
rhatdan
reviewed
Nov 1, 2019
|
|
||
| "github.com/containers/libpod/libpod" | ||
| log "github.com/sirupsen/logrus" | ||
|
|
rhatdan
reviewed
Nov 1, 2019
| func NewServer(runtime *libpod.Runtime) (*HttpServer, error) { | ||
| listeners, err := activation.Listeners() | ||
| if err != nil { | ||
| log.Panicf("Cannot retrieve listeners: %s", err) |
Author
There was a problem hiding this comment.
Panic is easier for now. Will move to errors once we wire everything in.
| log.Panicf("Cannot retrieve listeners: %s", err) | ||
| } | ||
| if len(listeners) != 1 { | ||
| log.Panicf("unexpected number of socket activation (%d != 1)", len(listeners)) |
| defer cancel() | ||
| server.SetKeepAlivesEnabled(false) | ||
| if err := server.Shutdown(ctx); err != nil { | ||
| log.Panicf("cannot gracefully shut down the http server: %s", err) |
| func (s *HttpServer) Serve() error { | ||
| err := http.Serve(s.listener, nil) | ||
| if err != nil { | ||
| log.Panicf("Cannot start server: %s", err) |
Use cd cmd/service && go build . $ systemd-socket-activate -l 8081 cmd/service/service & $ curl http://localhost:8081/v1.24/images/json Signed-off-by: Jhon Honce <jhonce@redhat.com>
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jhon Honce jhonce@redhat.com