Jp parsing #80
Merged
Jp parsing #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norgevz
reviewed
Oct 8, 2025
Done |
norgevz
reviewed
Oct 10, 2025
model/main.py
Outdated
| all_token_content = renderer.wrap_all_token_details(all_token_content) | ||
| content += all_token_content | ||
| model = renderer.get_model(country) | ||
| if model is not None: |
There was a problem hiding this comment.
Can we just have if model:here? It is simpler to parse that is not None.
There was a problem hiding this comment.
We can, I replaced it by if model: and did the same in other files.
model/renderer.py
Outdated
|
|
||
| countries = [] | ||
| vendor_extension_extra_pages: List[ExtraPage] = [] | ||
| LEGACY_COUNTRY_CODE = "XX" |
There was a problem hiding this comment.
This is defined, but not used. Why do we need this?
There was a problem hiding this comment.
This is used in other CL (related to this one) that I also sent for review.
There was a problem hiding this comment.
Let's define this where it's used.
norgevz
approved these changes
Oct 10, 2025
model/renderer.py
Outdated
|
|
||
| countries = [] | ||
| vendor_extension_extra_pages: List[ExtraPage] = [] | ||
| LEGACY_COUNTRY_CODE = "XX" |
There was a problem hiding this comment.
Let's define this where it's used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.