assert_file_contains: print regex on error #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit surprised that No Test failed. Please add a test that checks for the new output. |
zeeke
force-pushed
the
improve_assert_file_contains
branch
from
d83aee5
to
10a19bd
Compare
martin-schulze-vireso
approved these changes
Mar 25, 2023
In case of assertion failure, seeing the missing regex in the test output is helpful. Add unit test on assertion output. Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
improve_assert_file_contains
branch
from
10a19bd
to
a5af548
Compare
|
Thanks for your contribution! |
|
It seems we got an incomplete accidental addition of bats-support as submodule here. I reverted this change and should be more careful with reviews next time. |
|
Sorry for that, I haven't noticed it when I pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of assertion failure, seeing the missing regex in the test output is helpful.
This PR change the
assert_file_contains /home/test/file1.txt regex1output from:to