Embed recommended high altitude rule into prayer calculations #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering what your thoughts are on baking in the high altitude recommendation into the prayer calculations. I tried to do this in a backwards compatible way so the multiple nil-coalescing is a little funky.
You can see I had to fix a unit test that was failing because of this change, but it's a good failing because this change caught a non-sense prayer times table for the UK.
This PR is in draft mode until discussed and repointed to
develop
branch after it gets updated.