Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Egyptian calculation method parameters #29

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Fix Egyptian calculation method parameters #29

merged 1 commit into from
Mar 6, 2021

Conversation

ahmedre
Copy link
Collaborator

@ahmedre ahmedre commented Mar 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2021 •
edited
Loading

Codecov Report

Merging #29 (62a2191) into master (54f36a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     93.80%   93.80%           
  Complexity      136      136           
=========================================
  Files            20       20           
  Lines           500      500           
  Branches         45       45           
=========================================
  Hits            469      469           
  Misses           20       20           
  Partials         11       11
Impacted Files Coverage Δ Complexity Δ
...n/java/com/batoulapps/adhan/CalculationMethod.java 93.75% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f36a1...62a2191. Read the comment docs.

@iamriajul iamriajul mentioned this pull request Mar 6, 2021
Closed
@ahmedre ahmedre merged commit 4087faf into master Mar 6, 2021
@ahmedre ahmedre deleted the fix_egyptian_calculation_method branch March 6, 2021 14:18
@ahmedre ahmedre mentioned this pull request Mar 6, 2021
Closed
iamriajul added a commit to iamriajul/adhan-dart that referenced this pull request Mar 7, 2021
@iamriajul
fix(CalculationMethod): CalculationMethod.egyptian has wrong fajrAngl…
7de7a78 
…e and ishaAngle

batoulapps/adhan-kotlin#29

Closes #8
@iamriajul iamriajul mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3bi z3bi z3bi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedre @z3bi