Fix decoding of DI bits #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi argilo, thanks for the PR and contributing back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KubaPro010 reported in gqrx-sdr/gqrx#1360 that DI bits (mono/stereo, dynamic head, etc) are not parsed correctly in Gqrx, and @vladisslav2011 proposed a fix in gqrx-sdr/gqrx#1361. Because Gqrx has copied
parser_impl.ccandparser_impl.hfrom gr-rds, I would like to propose the changes upstream before accepting them in Gqrx.Two issues are fixed here:
I tested this out with some local stations, and Mono/Stereo is now correctly indicated in the panel.