Skip to content

fix(auto-sync): retry setup on next launch when any step fails #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lavaman131 merged 1 commit into from
Apr 13, 2026
Merged

fix(auto-sync): retry setup on next launch when any step fails #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/services/system/auto-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
*
* Failures are collected and reported as a summary at the end, but never
* abort the run — partial setup matches the production installer's
* "best-effort" semantics. The marker is written after every run (success
* or partial) so we don't re-attempt the whole setup on every subsequent
* launch.
* "best-effort" semantics. The marker is only written when every step
* succeeds; on partial failure the next launch re-runs all steps (they
* are idempotent, so re-running already-succeeded steps is harmless).
*/

import { join } from "node:path";
Expand Down Expand Up @@ -109,18 +109,21 @@ export async function autoSyncIfStale(): Promise<void> {
],
]);

// Always write the marker — partial setup is the production-installer
// contract. Re-running the bootstrap installer or `bun update -g
// @bastani/atomic` is the recovery path for a failed setup.
await markSynced();
const failures = results.filter((r) => !r.ok);

// Only write the marker when every step succeeded. On partial failure
// the next launch will re-run all steps — they're idempotent, so
// re-running already-succeeded steps is cheap and harmless.
if (failures.length === 0) {
await markSynced();
}

displayBlockBanner();
printSummary(results);

const failures = results.filter((r) => !r.ok);
if (failures.length > 0) {
console.log(
`\n ${COLORS.dim}Re-run \`bun install -g @bastani/atomic\` after resolving the issues to retry.${COLORS.reset}\n`,
`\n ${COLORS.dim}Setup will retry on next launch. To retry now, re-run your command.${COLORS.reset}\n`,
);
} else {
console.log(
Expand Down
Loading