Skip to content

chore(banner): refresh ANSI logo constants - #272

Merged
flora131 merged 1 commit into
mainfrom
flora131/feature/update-ascii-art
Feb 24, 2026
Merged

chore(banner): refresh ANSI logo constants#272
flora131 merged 1 commit into
mainfrom
flora131/feature/update-ascii-art

Conversation

@flora131

@flora131 flora131 commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updated the ANSI-colored logo art constants for the atomic CLI banner, refreshing both the true color (24-bit) and 256-color fallback versions.

Changes

  • Refreshed LOGO_TRUE_COLOR constant with updated 24-bit ANSI escape sequences
  • Refreshed LOGO constant with updated 256-color ANSI escape sequences
  • Logo dimensions remain unchanged (min cols: 79, min rows: 27)
  • Net reduction of 6 lines through optimized ANSI sequences

Technical Details

The changes update the pre-computed banner assets in src/utils/banner/constants.ts, maintaining compatibility with terminals that support different color depths while potentially improving the visual quality of the logo rendering.

Assistant-model: gpt-5.3-codex
@flora131
flora131 marked this pull request as ready for review February 24, 2026 08:29
Copilot AI review requested due to automatic review settings February 24, 2026 08:29
@flora131
flora131 merged commit a8332cb into main Feb 24, 2026
5 checks passed
@claude

claude Bot commented Feb 24, 2026

Copy link
Copy Markdown

PR Review: chore(banner): refresh ANSI logo constants

Thanks for the PR! I've reviewed the changes. Here's my feedback:

Summary

This PR updates the LOGO_TRUE_COLOR constant in src/utils/banner/constants.ts, refreshing the 24-bit true color ANSI art logo displayed in the CLI.


✅ What looks good

  1. Clean change scope: The PR is focused on a single concern - updating the visual banner art
  2. No functional changes: The update only affects the visual representation, not the display logic
  3. Preserves existing fallback: The 256-color LOGO constant remains unchanged, maintaining compatibility for terminals without true color support
  4. Dimension constants unchanged: LOGO_MIN_COLS (79) and LOGO_MIN_ROWS (27) are preserved

🤔 Questions / Suggestions

  1. Visual verification: Has the new logo been tested to render correctly in:

    • True color terminals (e.g., iTerm2, Windows Terminal, modern GNOME Terminal)?
    • Various terminal widths around the 79-column minimum?
  2. Dimension compatibility: The logo art appears to have different dimensions (net -6 lines). Please verify the new art fits within the LOGO_MIN_COLS (79) and LOGO_MIN_ROWS (27) constraints to avoid display issues.

  3. Fallback consistency: The true color logo appears to have a different visual design than the 256-color fallback (LOGO). Is this intentional? Users on different terminals may see visually different logos. Consider whether both versions should be updated together for consistency.


📝 Minor Observations

  • No tests affected: There are no unit tests for the banner constants, which is reasonable for static visual assets. However, if visual regression is a concern, consider adding a simple dimension check test.

Verdict

The change looks safe from a code quality perspective. My main recommendation is to verify the new logo renders correctly and confirm the dimension requirements are still met before merging.

Would be helpful if you could share a screenshot of the new logo rendering in a terminal! 📸

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the ANSI logo constants used for the atomic CLI banner display. The changes replace both the true color (24-bit) and 256-color ANSI escape sequences with new logo artwork.

Changes:

  • Replaced LOGO_TRUE_COLOR constant with new 10-line logo (previously ~34 lines)
  • Replaced LOGO constant (256-color fallback) with corresponding new 10-line logo
  • Both logos use the same new design with different color encoding schemes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude claude Bot mentioned this pull request Feb 25, 2026
@lavaman131
lavaman131 deleted the flora131/feature/update-ascii-art branch March 19, 2026 15:42
lavaman131 pushed a commit that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants