Skip to content

chore(skills): simplify sl-commit and sl-submit-diff skill docs #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flora131 merged 3 commits into from
Feb 23, 2026
Merged

chore(skills): simplify sl-commit and sl-submit-diff skill docs #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b0f08d
chore(skills): simplify sl-commit and sl-submit-diff skill docs
flora131 Feb 23, 2026
b4330f0
chore(skills): remove redundant commit types list from sl-commit docs
flora131 Feb 23, 2026
cd12006
chore(skills): remove sl ssl and status query commands from sl-submit…
flora131 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions .claude/skills/sl-commit/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,14 @@ Create well-formatted commits following the Conventional Commits specification u
## Commands to Use

- `sl status` - Check repository state
- `sl bookmark` - Get current bookmark
- `sl smartlog -l 5` - View recent commits with graphical history
- `sl diff --stat` - View pending changes
- `sl diff` - View pending changes
- `sl add <files>` - Add untracked files
- `sl commit -m "<message>"` - Create commit

## Key Sapling Differences from Git

- **No staging area**: Sapling commits all pending changes directly
- **Amend with auto-restack**: `sl amend` automatically rebases descendant commits
- **Smartlog**: Use `sl smartlog` or `sl ssl` for graphical commit history
- **Absorb**: Use `sl absorb` to intelligently integrate pending changes
- **Stacked Diffs**: Each commit becomes a separate Phabricator diff

## Sapling Commit Commands Reference
Expand All @@ -46,28 +42,6 @@ Create well-formatted commits following the Conventional Commits specification u
| `sl commit -A` | Add untracked files and commit |
| `sl amend` | Amend current commit (auto-rebases descendants) |
| `sl amend --to COMMIT` | Amend changes to a specific commit in stack |
| `sl absorb` | Intelligently absorb changes into stack commits |

## Conventional Commits Format

```
<type>[optional scope]: <description>

[optional body]

[optional footer(s)]
```

**Types:**

- `feat:` - New feature (MINOR version bump)
- `fix:` - Bug fix (PATCH version bump)
- `docs:` - Documentation changes
- `style:` - Code style changes
- `refactor:` - Code refactoring
- `perf:` - Performance improvements
- `test:` - Adding or updating tests
- `chore:` - Maintenance tasks

## Important Notes

Expand Down
20 changes: 5 additions & 15 deletions .claude/skills/sl-submit-diff/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Submit commits as Phabricator diffs for code review using Sapling.

# Submit Diff (Sapling + Phabricator)

Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc diff` (open-source).
Submit commits to Phabricator for code review using `jf submit` (Meta).

<EXTREMELY_IMPORTANT>

Expand All @@ -15,26 +15,22 @@ Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc d
## What This Skill Does

1. If there are uncommitted changes, first run `/commit` to create a commit
2. Submit commits to Phabricator using `jf submit` (or `arc diff`)
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text "Submit for review using DRAFT mode" is redundant with the first part of the sentence. The sentence currently reads: "Submit commits to Phabricator using jf submit --draft. Submit for review using DRAFT mode". Consider simplifying to just: "Submit commits to Phabricator using jf submit --draft" or rewording to: "Submit commits to Phabricator in DRAFT mode using jf submit --draft"

Suggested change
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode
2. Submit commits to Phabricator in DRAFT mode using `jf submit --draft`

Copilot uses AI. Check for mistakes.
3. Each commit in the stack becomes a separate Phabricator diff (D12345)
4. Commit messages are updated with `Differential Revision:` link

## Commands to Use

- `sl status` - Check for uncommitted changes
- `sl ssl` - View commits with diff status
- `jf submit` - Submit commits to Phabricator
- `jf submit --draft` - Submit commits to Phabricator in DRAFT mode
- `sl diff --since-last-submit` - View changes since last submission

## Common Operations

| Task | Command |
| ----------------------- | --------------------------------- |
| Submit current commit | `jf submit` |
| Update diff after amend | `sl amend && jf submit` |
| View diff status | `sl ssl` |
| Check sync status | `sl log -T '{syncstatus}\n' -r .` |
| Get diff ID | `sl log -T '{phabdiff}\n' -r .` |
| Submit current commit | `jf submit --draft` |
| Update diff after amend | `sl amend && jf submit --draft` |

## Diff Status Values

Expand All @@ -52,12 +48,6 @@ Sapling naturally supports stacked commits. When submitting:
- Diffs are linked with proper dependency relationships
- Reviewers can review each diff independently

## Prerequisites

1. **`.arcconfig`** must exist in repository root with Phabricator URL
2. **`~/.arcrc`** must contain authentication credentials
3. **`fbcodereview`** extension must be enabled in Sapling config

## Important Notes

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Prerequisites section may cause confusion for users who need to set up Phabricator integration. While this section is being removed from the skill docs, the prerequisites are still documented in other parts of the codebase (specs/source-control-type-selection.md, README.md) and are still actual requirements for using jf submit. Consider adding a brief note directing users to setup documentation, such as: "Note: Requires Phabricator configuration (.arcconfig). See repository setup documentation for details."

Suggested change
- Note: Requires Phabricator configuration (`.arcconfig`). See repository setup documentation for details.

Copilot uses AI. Check for mistakes.
- Unlike GitHub PRs, Phabricator diffs are tied to commits via `Differential Revision:`
Expand Down
28 changes: 1 addition & 27 deletions .github/skills/sl-commit/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,14 @@ Create well-formatted commits following the Conventional Commits specification u
## Commands to Use

- `sl status` - Check repository state
- `sl bookmark` - Get current bookmark
- `sl smartlog -l 5` - View recent commits with graphical history
- `sl diff --stat` - View pending changes
- `sl diff` - View pending changes
- `sl add <files>` - Add untracked files
- `sl commit -m "<message>"` - Create commit

## Key Sapling Differences from Git

- **No staging area**: Sapling commits all pending changes directly
- **Amend with auto-restack**: `sl amend` automatically rebases descendant commits
- **Smartlog**: Use `sl smartlog` or `sl ssl` for graphical commit history
- **Absorb**: Use `sl absorb` to intelligently integrate pending changes
- **Stacked Diffs**: Each commit becomes a separate Phabricator diff

## Sapling Commit Commands Reference
Expand All @@ -46,28 +42,6 @@ Create well-formatted commits following the Conventional Commits specification u
| `sl commit -A` | Add untracked files and commit |
| `sl amend` | Amend current commit (auto-rebases descendants) |
| `sl amend --to COMMIT` | Amend changes to a specific commit in stack |
| `sl absorb` | Intelligently absorb changes into stack commits |

## Conventional Commits Format

```
<type>[optional scope]: <description>

[optional body]

[optional footer(s)]
```

**Types:**

- `feat:` - New feature (MINOR version bump)
- `fix:` - Bug fix (PATCH version bump)
- `docs:` - Documentation changes
- `style:` - Code style changes
- `refactor:` - Code refactoring
- `perf:` - Performance improvements
- `test:` - Adding or updating tests
- `chore:` - Maintenance tasks

## Important Notes

Expand Down
20 changes: 5 additions & 15 deletions .github/skills/sl-submit-diff/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Submit commits as Phabricator diffs for code review using Sapling.

# Submit Diff (Sapling + Phabricator)

Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc diff` (open-source).
Submit commits to Phabricator for code review using `jf submit` (Meta).

<EXTREMELY_IMPORTANT>

Expand All @@ -15,26 +15,22 @@ Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc d
## What This Skill Does

1. If there are uncommitted changes, first run `/commit` to create a commit
2. Submit commits to Phabricator using `jf submit` (or `arc diff`)
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text "Submit for review using DRAFT mode" is redundant with the first part of the sentence. The sentence currently reads: "Submit commits to Phabricator using jf submit --draft. Submit for review using DRAFT mode". Consider simplifying to just: "Submit commits to Phabricator using jf submit --draft" or rewording to: "Submit commits to Phabricator in DRAFT mode using jf submit --draft"

Suggested change
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode
2. Submit commits to Phabricator in DRAFT mode using `jf submit --draft`

Copilot uses AI. Check for mistakes.
3. Each commit in the stack becomes a separate Phabricator diff (D12345)
4. Commit messages are updated with `Differential Revision:` link

## Commands to Use

- `sl status` - Check for uncommitted changes
- `sl ssl` - View commits with diff status
- `jf submit` - Submit commits to Phabricator
- `jf submit --draft` - Submit commits to Phabricator in DRAFT mode
- `sl diff --since-last-submit` - View changes since last submission

## Common Operations

| Task | Command |
| ----------------------- | --------------------------------- |
| Submit current commit | `jf submit` |
| Update diff after amend | `sl amend && jf submit` |
| View diff status | `sl ssl` |
| Check sync status | `sl log -T '{syncstatus}\n' -r .` |
| Get diff ID | `sl log -T '{phabdiff}\n' -r .` |
| Submit current commit | `jf submit --draft` |
| Update diff after amend | `sl amend && jf submit --draft` |

## Diff Status Values

Expand All @@ -52,12 +48,6 @@ Sapling naturally supports stacked commits. When submitting:
- Diffs are linked with proper dependency relationships
- Reviewers can review each diff independently

## Prerequisites

1. **`.arcconfig`** must exist in repository root with Phabricator URL
2. **`~/.arcrc`** must contain authentication credentials
3. **`fbcodereview`** extension must be enabled in Sapling config

## Important Notes

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Prerequisites section may cause confusion for users who need to set up Phabricator integration. While this section is being removed from the skill docs, the prerequisites are still documented in other parts of the codebase (specs/source-control-type-selection.md, README.md) and are still actual requirements for using jf submit. Consider adding a brief note directing users to setup documentation, such as: "Note: Requires Phabricator configuration (.arcconfig). See repository setup documentation for details."

Suggested change
- Note: Requires Phabricator configuration (`.arcconfig`). See repository setup documentation for details.

Copilot uses AI. Check for mistakes.
- Unlike GitHub PRs, Phabricator diffs are tied to commits via `Differential Revision:`
Expand Down
28 changes: 1 addition & 27 deletions .opencode/skills/sl-commit/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,14 @@ Create well-formatted commits following the Conventional Commits specification u
## Commands to Use

- `sl status` - Check repository state
- `sl bookmark` - Get current bookmark
- `sl smartlog -l 5` - View recent commits with graphical history
- `sl diff --stat` - View pending changes
- `sl diff` - View pending changes
- `sl add <files>` - Add untracked files
- `sl commit -m "<message>"` - Create commit

## Key Sapling Differences from Git

- **No staging area**: Sapling commits all pending changes directly
- **Amend with auto-restack**: `sl amend` automatically rebases descendant commits
- **Smartlog**: Use `sl smartlog` or `sl ssl` for graphical commit history
- **Absorb**: Use `sl absorb` to intelligently integrate pending changes
- **Stacked Diffs**: Each commit becomes a separate Phabricator diff

## Sapling Commit Commands Reference
Expand All @@ -46,28 +42,6 @@ Create well-formatted commits following the Conventional Commits specification u
| `sl commit -A` | Add untracked files and commit |
| `sl amend` | Amend current commit (auto-rebases descendants) |
| `sl amend --to COMMIT` | Amend changes to a specific commit in stack |
| `sl absorb` | Intelligently absorb changes into stack commits |

## Conventional Commits Format

```
<type>[optional scope]: <description>

[optional body]

[optional footer(s)]
```

**Types:**

- `feat:` - New feature (MINOR version bump)
- `fix:` - Bug fix (PATCH version bump)
- `docs:` - Documentation changes
- `style:` - Code style changes
- `refactor:` - Code refactoring
- `perf:` - Performance improvements
- `test:` - Adding or updating tests
- `chore:` - Maintenance tasks

## Important Notes

Expand Down
20 changes: 5 additions & 15 deletions .opencode/skills/sl-submit-diff/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Submit commits as Phabricator diffs for code review using Sapling.

# Submit Diff (Sapling + Phabricator)

Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc diff` (open-source).
Submit commits to Phabricator for code review using `jf submit` (Meta).

<EXTREMELY_IMPORTANT>

Expand All @@ -15,26 +15,22 @@ Submit commits to Phabricator for code review using `jf submit` (Meta) or `arc d
## What This Skill Does

1. If there are uncommitted changes, first run `/commit` to create a commit
2. Submit commits to Phabricator using `jf submit` (or `arc diff`)
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text "Submit for review using DRAFT mode" is redundant with the first part of the sentence. The sentence currently reads: "Submit commits to Phabricator using jf submit --draft. Submit for review using DRAFT mode". Consider simplifying to just: "Submit commits to Phabricator using jf submit --draft" or rewording to: "Submit commits to Phabricator in DRAFT mode using jf submit --draft"

Suggested change
2. Submit commits to Phabricator using `jf submit --draft`. Submit for review using DRAFT mode
2. Submit commits to Phabricator in DRAFT mode using `jf submit --draft`

Copilot uses AI. Check for mistakes.
3. Each commit in the stack becomes a separate Phabricator diff (D12345)
4. Commit messages are updated with `Differential Revision:` link

## Commands to Use

- `sl status` - Check for uncommitted changes
- `sl ssl` - View commits with diff status
- `jf submit` - Submit commits to Phabricator
- `jf submit --draft` - Submit commits to Phabricator in DRAFT mode
- `sl diff --since-last-submit` - View changes since last submission

## Common Operations

| Task | Command |
| ----------------------- | --------------------------------- |
| Submit current commit | `jf submit` |
| Update diff after amend | `sl amend && jf submit` |
| View diff status | `sl ssl` |
| Check sync status | `sl log -T '{syncstatus}\n' -r .` |
| Get diff ID | `sl log -T '{phabdiff}\n' -r .` |
| Submit current commit | `jf submit --draft` |
| Update diff after amend | `sl amend && jf submit --draft` |

## Diff Status Values

Expand All @@ -52,12 +48,6 @@ Sapling naturally supports stacked commits. When submitting:
- Diffs are linked with proper dependency relationships
- Reviewers can review each diff independently

## Prerequisites

1. **`.arcconfig`** must exist in repository root with Phabricator URL
2. **`~/.arcrc`** must contain authentication credentials
3. **`fbcodereview`** extension must be enabled in Sapling config

## Important Notes

Copilot AI Feb 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Prerequisites section may cause confusion for users who need to set up Phabricator integration. While this section is being removed from the skill docs, the prerequisites are still documented in other parts of the codebase (specs/source-control-type-selection.md, README.md) and are still actual requirements for using jf submit. Consider adding a brief note directing users to setup documentation, such as: "Note: Requires Phabricator configuration (.arcconfig). See repository setup documentation for details."

Suggested change
- Note: Requires Phabricator configuration (`.arcconfig`). See repository setup documentation for details.

Copilot uses AI. Check for mistakes.
- Unlike GitHub PRs, Phabricator diffs are tied to commits via `Differential Revision:`
Expand Down