Skip to content

fix(workflows): surface resumable runs on session restore - #1726

Closed
w3lld1 wants to merge 1 commit into
bastani-inc:mainfrom
w3lld1:fix/resume-workflow-notice
Closed

fix(workflows): surface resumable runs on session restore#1726
w3lld1 wants to merge 1 commit into
bastani-inc:mainfrom
w3lld1:fix/resume-workflow-notice

Conversation

@w3lld1

@w3lld1 w3lld1 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • detect resumable durable workflow references when an existing Atomic session starts or is resumed
  • show each workflow name, short ID, and exact /workflow resume <id> command
  • ignore completed, cancelled, and explicitly non-resumable workflows, using the latest cached state for each workflow

Validation

  • /tmp/bun-runtime/bun-linux-x64/bun test test/unit/resumable-workflow-notices.test.ts (2 passed)
  • git diff --check

The full workspace typecheck and test suite were not run locally because this runner did not have the repository dependencies installed and had insufficient disk space for a full bun install.

Fixes #1722

@lavaman131

Copy link
Copy Markdown
Collaborator

Thank you for adding the restored-session resume notice. During follow-up review, I found one eligibility gap: failed workflows with absent resumable metadata were omitted, even though durable workflow semantics treat failed (and blocked) runs as resumable unless they are explicitly marked resumable: false. A follow-up based on this work centralizes the eligibility rule and adds regression coverage: #1748. It supersedes/corrects this PR without changing its core intent.

@w3lld1

w3lld1 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the follow-up and for preserving the core intent in #1748. Closing this superseded PR to keep the review queue clear.

@w3lld1 w3lld1 closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resuming a session via --session does not re-attach/surface its running background workflow

2 participants