feat: overhaul impeccable skill and refresh agent guidance - #1125
Conversation
Refresh agent-facing guidance across the system prompt, subagents, and
workflow skills, and rebuild the impeccable design skill.
coding-agent:
- Replace the static engineering-principles block in the system prompt
with workflow-tool guidance (discover/run/inspect/steer workflows),
gated on whether the `workflow` tool is excluded. Add coverage in
system-prompt.test.ts.
subagents:
- Rework code-simplifier around the "doors" lens: read code as a set of
entrypoints that carry domain intent, refine interior mechanism freely
while keeping public contracts honest, and run a per-entrypoint rubric.
- Bump debugger to xhigh thinking and add the tmux skill for terminal/TUI
debugging.
workflows/create-spec:
- Rebuild the spec philosophy around entrypoints ("doors"): the door set
as a first-class artifact, the five principles, and a per-entrypoint
rubric. Fix the AskUserQuestion reference to ask_user_question.
workflows/impeccable:
- Migrate script paths from .claude/skills to .agents/skills and switch
invocations from /impeccable to $impeccable.
- Rename the teach command to init (with a deprecated teach alias) and
prune deprecated reference docs (cognitive-load, color-and-contrast,
motion-design, personas, responsive-design, spatial-design, teach,
typography, ux-writing, heuristics-scoring).
- Add context/context-signals/detect/palette scripts and a bundled
detector, plus an agents/ directory, for context-aware command routing.
- Rebuild live-mode browser/server tooling (manual-edit buffering, event
validation, UI insertion, copy-edit agent) and refresh SKILL.md design
laws.
Assistant-model: Claude Opus 4.8
PR review — overhaul impeccable skill and refresh agent guidanceBig PR (93 files, ~25k+/2.8k−). I read Correctness / bugs
Behavior consistency
Test coverageThis is the biggest gap. The PR ships ~12k lines of new mjs scripts and adds tests only for
The whole Also: CLAUDE.md says tests should use Security (defense in depth)
Code structure
Things I liked
Suggested priorities before merge
Everything else can be follow-up. Nice work on the scope of this refresh. |
Refresh agent-facing guidance across the system prompt, subagents, and
workflow skills, and rebuild the impeccable design skill.
coding-agent:
- Replace the static engineering-principles block in the system prompt
with workflow-tool guidance (discover/run/inspect/steer workflows),
gated on whether the `workflow` tool is excluded. Add coverage in
system-prompt.test.ts.
subagents:
- Rework code-simplifier around the "doors" lens: read code as a set of
entrypoints that carry domain intent, refine interior mechanism freely
while keeping public contracts honest, and run a per-entrypoint rubric.
- Bump debugger to xhigh thinking and add the tmux skill for terminal/TUI
debugging.
workflows/create-spec:
- Rebuild the spec philosophy around entrypoints ("doors"): the door set
as a first-class artifact, the five principles, and a per-entrypoint
rubric. Fix the AskUserQuestion reference to ask_user_question.
workflows/impeccable:
- Migrate script paths from .claude/skills to .agents/skills and switch
invocations from /impeccable to $impeccable.
- Rename the teach command to init (with a deprecated teach alias) and
prune deprecated reference docs (cognitive-load, color-and-contrast,
motion-design, personas, responsive-design, spatial-design, teach,
typography, ux-writing, heuristics-scoring).
- Add context/context-signals/detect/palette scripts and a bundled
detector, plus an agents/ directory, for context-aware command routing.
- Rebuild live-mode browser/server tooling (manual-edit buffering, event
validation, UI insertion, copy-edit agent) and refresh SKILL.md design
laws.
Assistant-model: Claude Opus 4.8
1 participant
Summary
Refreshes agent guidance across the core system prompt, builtin subagents, and workflow skills, and substantially rebuilds the `impeccable` design skill. The connective thread across the agent changes is the "doors"/entrypoints design lens — code and specs are read as sets of entrypoints that carry domain intent, with interior mechanism refined freely while public contracts stay honest. The `impeccable` overhaul adds context-aware command routing, a new design-antipattern detector, rebuilt live-mode browser tooling, and migrates paths/commands to the `.agents/` layout.
Changes
`packages/coding-agent`
`packages/subagents`
`packages/workflows` — `create-spec`
`packages/workflows` — `impeccable`
Migration / renames (breaking for local installs):
Pruned reference docs (stale / superseded):
`cognitive-load`, `color-and-contrast`, `heuristics-scoring`, `motion-design`, `personas`, `responsive-design`, `spatial-design`, `teach`, `typography`, `ux-writing`.
New capabilities:
Rebuilt live-mode tooling:
Refreshed `SKILL.md`: Tightened setup steps (context script first, then command reference, then register reference, then palette for greenfield); updated design laws.
Migration notes
If you have `impeccable` installed locally, update any path references from `.claude/skills/impeccable/` to `.agents/skills/impeccable/` and replace `/impeccable` invocations with `$impeccable`. The `teach` command still works but is deprecated — use `init` going forward.
Test results