Black screen on some mobile chrome and safari #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chrome and safari Fix basst314#95
yamaha252
commented
Nov 25, 2020
| @@ -56,9 +56,9 @@ export class WebcamComponent implements AfterViewInit, OnDestroy { | |||
| private switchCameraSubscription: Subscription; | |||
| /** MediaStream object in use for streaming UserMedia data */ | |||
| private mediaStream: MediaStream = null; | |||
| @ViewChild('video', { static: true }) private video: any; | |||
| @ViewChild('video', {static: true}) private video: any; | |||
There was a problem hiding this comment.
sorry for that changes
|
Thanks for the fix @yamaha252 - we are facing the problem mentioned in #95 as well. |
|
@yamaha252 Could you explain what the problem was? Why are your code changes fixing the problem? |
|
It seems twice execution of |
|
@basst314 Happy new year to you - it would be great if you could merge this sometime soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #95