Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout out in android browser #28

Closed
shoutao opened this issue Oct 10, 2018 · 9 comments
Closed

Layout out in android browser #28

shoutao opened this issue Oct 10, 2018 · 9 comments
Labels
bug Something isn't working

Comments

@shoutao
Copy link

shoutao commented Oct 10, 2018

The layout is gone in android browser.

@basst314
Copy link
Owner

Hi @shoutao,

Thanks for raising this.

Could you provide some more information on what the issue is exactly and how you use ngx-webcam in your project?
Do you see the same behaviour on the demo page linked from the readme?

I will try to reproduce and fix the issue as soon as possible.

Thanks!

@shoutao
Copy link
Author

shoutao commented Oct 16, 2018

Hi, Sorry for not describing it clearly. I have attached two screen shots which are taken on Samsung s6 using the demo page.
screenshot_20181016-094849
screenshot_20181016-094836

@basst314
Copy link
Owner

Hi @shoutao,
Thanks for the screenshots. I will be looking into it as soon as possible.

@frederiksen
Copy link

@shoutao try to rotate your android phone - when holding it horizontally, the web-cam component is filled correctly - when holding it normally - the web-cam component get's white boxes on the left/right sides.

@maurivillegas
Copy link

Hi @basst314
I'm facing the same problem on android smarthphones, please help us, the layout works ok on Horizontal, on Vertical Im having the same problem

@basst314
Copy link
Owner

I can reproduce the issue on an iPhone when rotating the phone after the page was loaded. A refresh in any orientation fixes the issue. Seems to be an issue with the CSS not being applied properly because of the changing dimensions of the video element.

Looking into it...

@basst314
Copy link
Owner

Found out that apparently Android devices return the wrong aspectRatio for portrait video streams. The aspectRatio always indicates a landscape video, therefore the bounding box is calculated incorrectly and the switch-button shows up in the wrong place.

working on a fix.

@basst314
Copy link
Owner

Hi @shoutao and @frederiksen,

I'm happy to let you know that I published a fix for this issue in the current release 0.2.2.

I tested the fix on all my devices (iOS+Android) and it resolved the bug!

In case something's still not working as expected, feel free to create a new issue here.

Cheers!

@shoutao
Copy link
Author

shoutao commented Jan 14, 2019

Really appreciate your working.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants