Update proxy_overload_recovery to handle indeterminism more gracefully. #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `prepare` so that it waits for the vnode PID to change as it's possible that monitors haven't fired by the time we ask for a new one - Update `drain` to require 3 consecutive 0 counts from a group of PIDs rather than draining individual processes or only trying once. The number 3 was determined empirically - read the comment above `drain` if it continues to cause issues. - Rewrite `resume` to make sure things are drained properly before continuing.
Contributor
|
+1 9551318 |
JeetKunDoug
added a commit
that referenced
this pull request
Dec 1, 2015
…_2.0 Update proxy_overload_recovery to handle indeterminism more gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepareso that it waits for the vnode PID to change as it'spossible that monitors haven't fired by the time we ask for a new one
drainto require 3 consecutive 0 counts from a group of PIDsrather than draining individual processes or only trying once. The
number 3 was determined empirically - read the comment above
drainif it continues to cause issues.
resumeto make sure things are drained properly beforecontinuing.