Update tests for different default bucket properties #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overriding default_bucket_props in advanced_config without explicitly setting these returns different values with the fix for allow_mult turning to true with an app.config file present.
|
👍 |
JeetKunDoug
added a commit
that referenced
this pull request
Nov 25, 2015
…nt_default_bucket_properties Update tests for different default bucket properties
hazen
deleted the
dr/bugfix/update_tests_for_different_default_bucket_properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Riak 2.1.2 there's been a small, subtle change made in the way that default bucket properties work. To ensure all our tests keep working the same way, we need to explicitly specify settings for allow_mult and dvv_enabled whenever we have a custom value set for riak_core.default_bucket_props. Most of these changes may not be strictly necessary, but we do at least need the change to repl_aae_fullsync, and in general it's better to be explicit about what we expect.
For more background, see basho/riak_core#765
This PR also includes a couple of indentation fixes, and a small, unrelated change that adds some extra logging to wait_until_no_pending_changes.
Doug and I ran through each of the modified tests as well, just to verify that nothing was broken by these changes.